Skip to content

Commit

Permalink
prefer firefox over chrome (#388)
Browse files Browse the repository at this point in the history
  • Loading branch information
asnyv authored Jan 26, 2021
1 parent 8dc0a12 commit 0c20d16
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ Authorization Code flow support for Azure AD applications.
### Changed
- [#374](https://github.com/equinor/webviz-config/pull/374) - Removed Webviz
SSL certificate generation and forcing of HTTPS connections.
- [#388](https://github.com/equinor/webviz-config/pull/388) - Firefox preferred as
default browser over Chrome/Chromium to ease the transition on localhost after #374.
Browser defined with `webviz preferences --browser somebrowser` is still used instead
of the new default (Firefox).

### Fixed
- [#380](https://github.com/equinor/webviz-config/pull/380) - Don't write warning
Expand Down
2 changes: 1 addition & 1 deletion webviz_config/utils/_localhost_open_browser.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def _get_browser_controller() -> webbrowser.BaseBrowser:
except webbrowser.Error:
warnings.warn("Could not find the user preferred browser.")

for browser in ["chrome", "chromium-browser"]:
for browser in ["firefox", "chrome", "chromium-browser"]:
try:
return webbrowser.get(using=browser)
except webbrowser.Error:
Expand Down

0 comments on commit 0c20d16

Please sign in to comment.