Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade release-please #244

Merged
merged 1 commit into from
Jul 22, 2024
Merged

chore: upgrade release-please #244

merged 1 commit into from
Jul 22, 2024

Conversation

soofstad
Copy link
Collaborator

Why is this pull request needed?

Upgrade to latest release-please with manifest

@soofstad soofstad self-assigned this Jul 22, 2024
@soofstad soofstad requested a review from a team as a code owner July 22, 2024 08:36
sebastianvitterso
sebastianvitterso approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@sebastianvitterso sebastianvitterso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a second there I thought we were getting rid of the config, but at least this is better (json in a json file, instead of in a yaml file).

.github/workflows/create-release-pr.yaml Show resolved Hide resolved
release-please-config.json Show resolved Hide resolved
@soofstad soofstad merged commit 381ee02 into main Jul 22, 2024
7 checks passed
@soofstad soofstad deleted the chore/upgrade-release-please branch July 22, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianvitterso sebastianvitterso sebastianvitterso approved these changes

Assignees

@soofstad soofstad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soofstad @sebastianvitterso