Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dynatrace information #287

Merged
merged 11 commits into from
Dec 11, 2023
Merged

Add Dynatrace information #287

merged 11 commits into from
Dec 11, 2023

Conversation

Richard87
Copy link
Contributor

@Richard87 Richard87 commented Nov 30, 2023 •
edited
Loading

@Richard87 Richard87 self-assigned this Nov 30, 2023
@Richard87 Richard87 marked this pull request as draft November 30, 2023 13:29
@Richard87 Richard87 requested a review from satr December 8, 2023 08:55
@Richard87 Richard87 marked this pull request as ready for review December 8, 2023 08:55
satr
satr reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@satr satr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of internal links needs to be approved by PO

@Richard87 Richard87 requested a review from emirgens December 11, 2023 08:47
emirgens
emirgens requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@emirgens emirgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see the issue, these links will work without the token. Then the access is "protected"

public-site/docs/src/docs/topic-dynatrace-int/index.md Outdated Show resolved Hide resolved
public-site/docs/src/docs/topic-dynatrace-int/index.md Outdated Show resolved Hide resolved
@Richard87 Richard87 requested a review from emirgens December 11, 2023 12:41
emirgens
emirgens approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@emirgens emirgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Richard87 Richard87 merged commit bfd5a87 into main Dec 11, 2023
3 checks passed
@Richard87 Richard87 deleted the dynatrace-config branch December 11, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satr satr satr left review comments

@emirgens emirgens emirgens approved these changes

Assignees

@Richard87 Richard87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Richard87 @satr @emirgens