Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-deploy documentation #273

Merged
merged 16 commits into from
Nov 13, 2023
Merged

Conversation

nilsgstrabo
Copy link
Contributor

No description provided.

@nilsgstrabo nilsgstrabo self-assigned this Nov 9, 2023
@nilsgstrabo nilsgstrabo marked this pull request as ready for review November 10, 2023 12:54
Comment on lines 97 to 100
- Pipelines created manually from `Radix Web Console` or `Radix CLI` will always build all components and jobs.
- When pipelines are created from a `Github webhook`, Radix will only build components and jobs that affected by the changes, and reuse images from the active deployment for unchanged components/jobs.
- When Radix detects that `radixconfig.yaml` is modified, all components and jobs are built.
- When `build secret` values are updated, the next pipeline job will build all components and jobs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this on top, this is the main thing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@emirgens emirgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much text for me to understand, but see my comment in text


There are few options how the code can be located in the GitHub repository for a Radix application:
For manually created pipeline jobs, Radix will always build all components and jobs. When a pipeline job is created from a Github webhook, Radix compares the commit ID from the webhook request body with the commit ID of the active deployment to detect which directories have changed. The list of changed directories are then compared to the `src` property for each component and job, and if any of the changed directories are equal to, or a child of `src`, a new image is built for the component/job. Radix will reuse the image from the current active deployment for components and jobs that have not changed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For manually created pipeline jobs, Radix will always build all components and jobs. When a pipeline job is created from a Github webhook, Radix compares the commit ID from the webhook request body with the commit ID of the active deployment to detect which directories have changed. The list of changed directories are then compared to the `src` property for each component and job, and if any of the changed directories are equal to, or a child of `src`, a new image is built for the component/job. Radix will reuse the image from the current active deployment for components and jobs that have not changed.
For manually created pipeline jobs, Radix will always build all components and jobs without defined property `image`. When a pipeline job is created by a Github webhook, Radix compares the commit ID from the webhook request body with the commit ID of the active deployment to detect which directories have changed. The list of changed directories are then compared to the `src` property for each component and job:
* If any of the changed directories are within the directory, defined in `src` or are its sub-directories, a new image is built for the component and job.
* if no such changes detected, Radix will reuse the image from the current active deployment for components and jobs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is described in the previous paragraph. I don't think there is a need to describe it one more time.

@nilsgstrabo nilsgstrabo requested review from satr and emirgens November 13, 2023 09:20
Copy link
Contributor

@Richard87 Richard87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tiny comment on word splitting (Dockerfiles)

public-site/docs/src/guides/build-and-deploy/index.md Outdated Show resolved Hide resolved
Richard87
Richard87 previously approved these changes Nov 13, 2023
Copy link
Contributor

@Richard87 Richard87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

satr
satr previously approved these changes Nov 13, 2023
@nilsgstrabo nilsgstrabo merged commit eb24b1c into main Nov 13, 2023
3 checks passed
@nilsgstrabo nilsgstrabo deleted the rebuild-changed-components-only branch November 13, 2023 15:09
@emirgens emirgens linked an issue Nov 14, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants