feat: Add Healtchchecks to RadixConfig #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Richard87
commented
Dec 2, 2024
•
Richard87
commented
- Validate only of probe handler is defined
- Test data is copied correctly
3 tasks
nilsgstrabo
requested changes
Dec 10, 2024
| PeriodSeconds: pointers.Val(rp.PeriodSeconds), | ||
| SuccessThreshold: pointers.Val(rp.SuccessThreshold), | ||
| FailureThreshold: pointers.Val(rp.FailureThreshold), | ||
| // TerminationGracePeriodSeconds: rp.TerminationGracePeriodSeconds, |
There was a problem hiding this comment.
Suggested change
| // TerminationGracePeriodSeconds: rp.TerminationGracePeriodSeconds, |
Suggest we remove this if we don't intend to use it
nilsgstrabo
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.