Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create validate command #75

Merged
merged 16 commits into from
Nov 10, 2023
Merged

Create validate command #75

merged 16 commits into from
Nov 10, 2023

Conversation

Richard87
Copy link
Contributor

@Richard87 Richard87 commented Nov 2, 2023 •
edited
Loading

Todo:

Example output:

go run . validate radix-config -c /home/richard/Projects/edc/rihag-edc23-radix-1/radixconfig.yaml
env prodtest refered to by component web is not defined: environment referenced by component does not exist
env devbla refered to by component redis is not defined: environment referenced by component does not exist
Error: Radix Config is invalid
exit status 1

@Richard87 Richard87 requested a review from nilsgstrabo November 3, 2023 07:15
nilsgstrabo
nilsgstrabo requested changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@nilsgstrabo nilsgstrabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions

cmd/validate.go Outdated Show resolved Hide resolved
cmd/validate.go Outdated Show resolved Hide resolved
@nilsgstrabo nilsgstrabo self-requested a review November 8, 2023 07:31
nilsgstrabo
nilsgstrabo requested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@nilsgstrabo nilsgstrabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes. Also run go mod tidy

cmd/validate.go Outdated Show resolved Hide resolved
cmd/validate.go Outdated Show resolved Hide resolved
cmd/validate.go Outdated Show resolved Hide resolved
cmd/validate.go Outdated Show resolved Hide resolved
cmd/validate.go Outdated Show resolved Hide resolved
cmd/validate.go Outdated Show resolved Hide resolved
cmd/validate.go Outdated Show resolved Hide resolved
@Richard87 Richard87 requested a review from nilsgstrabo November 8, 2023 09:46
nilsgstrabo
nilsgstrabo requested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@nilsgstrabo nilsgstrabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few minor changes

cmd/validateRadixConfig.go Outdated Show resolved Hide resolved
cmd/validateRadixConfig.go Outdated Show resolved Hide resolved
cmd/validateRadixConfig.go Outdated Show resolved Hide resolved
@nilsgstrabo nilsgstrabo self-requested a review November 10, 2023 08:43
@Richard87 Richard87 merged commit 3ec779b into master Nov 10, 2023
2 checks passed
@Richard87 Richard87 deleted the validate-command branch November 10, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsgstrabo nilsgstrabo nilsgstrabo approved these changes

Assignees

@Richard87 Richard87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Richard87 @nilsgstrabo