Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests #936

Merged
merged 4 commits into from
Feb 28, 2024
Merged

test: add tests #936

merged 4 commits into from
Feb 28, 2024

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner February 27, 2024 20:25
EvenSol
EvenSol approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good test. All derivatives have not been implemented for PC-SAFT as you see.
Therefore properties requiring higher order derivatives might be wrong (eg. Cp), but I'm not sure. Fugacity and density should be ok. But I think how you have set it up is fine.

@asmfstatoil
Copy link
Collaborator Author

All the test values are fine at my mac, but the values found in the build env are quite different so that speaks of some numerical issues. Especially seen for higher order derivatives.

Regarding the non-implemented functions, my intent here was to add tests before removing the methods that are purely redundant copies of code in parent class phasepcsaft.java.

Interestingly I also saw that the phasepcsaftrahmat was in use for systempcsaft, not phasepcsaft

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.69%. Comparing base (db6cb52) to head (2df4975).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #936      +/-   ##
============================================
+ Coverage     33.69%   34.69%   +0.99%     
- Complexity     5129     5274     +145     
============================================
  Files           700      700              
  Lines         69741    69741              
  Branches       7984     7984              
============================================
+ Hits          23501    24196     +695     
+ Misses        44763    44063     -700     
- Partials       1477     1482       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol
Copy link
Collaborator

EvenSol commented Feb 28, 2024 •
edited
Loading

All the test values are fine at my mac, but the values found in the build env are quite different so that speaks of some numerical issues. Especially seen for higher order derivatives.

Regarding the non-implemented functions, my intent here was to add tests before removing the methods that are purely redundant copies of code in parent class phasepcsaft.java.

Interestingly I also saw that the phasepcsaftrahmat was in use for systempcsaft, not phasepcsaft

Yes - this is ok. The model was developed as part of the PhD thesis by Rhamat W.:
https://ntnuopen.ntnu.no/ntnu-xmlui/handle/11250/2564750

@asmfstatoil
Copy link
Collaborator Author

Nice, be free to merge it when you are ready

@EvenSol EvenSol merged commit 388d877 into equinor:master Feb 28, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the test_rahmat branch February 29, 2024 07:30
EvenSol added a commit that referenced this pull request Aug 15, 2024
@EvenSol @snyk-bot
@Sviatose @asmfstatoil @jorgenengelsen
updated with master (#1080)
8bf9809 
* fix: upgrade org.ojalgo:ojalgo from 53.1.0 to 53.1.1 (#837)

Snyk has created this PR to upgrade org.ojalgo:ojalgo from 53.1.0 to 53.1.1.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.ojalgo/ojalgo/

See this project in Snyk:
https://app.snyk.io/org/evensol/project/5734e76a-5ebe-4fe0-9fb9-776e0cbc8504?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* added flow setter (#838)

* added flow setter

* improve setter

* fix bug

* fix errors

* fix: upgrade org.apache.logging.log4j:log4j-core from 2.20.0 to 2.21.0 (#840)

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-core from 2.20.0 to 2.21.0.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-core/

See this project in Snyk:
https://app.snyk.io/org/evensol/project/5734e76a-5ebe-4fe0-9fb9-776e0cbc8504?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* fix: upgrade org.apache.logging.log4j:log4j-api from 2.20.0 to 2.21.0 (#839)

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.20.0 to 2.21.0.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-api/

See this project in Snyk:
https://app.snyk.io/org/evensol/project/5734e76a-5ebe-4fe0-9fb9-776e0cbc8504?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* added test for flow setter for simple process (#841)

* Bug  error with flash calc (#843)

* bug: error with flash calc Gudrun

* temporary "fix" bug in stabiilty analysis

---------

Co-authored-by: Sviatoslav Eroshkin <[email protected]>

* Fix multifeed (#845)

* fixed minor bug in stability analysis

* fix multifeed

* update

* update

* fixed bug

* update

* remove log

* version 2.5.8

* fix flow setter bug

* feat: use defined constant values (#825)

* refact: use defined constant values for atmospheric pressure 
* refact: use defined constant value for R
style / docfix
---------

Co-authored-by: Even Solbraa <[email protected]>

* fix: upgrade org.apache.logging.log4j:log4j-core from 2.21.0 to 2.21.1 (#846)

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-core from 2.21.0 to 2.21.1.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-core/

See this project in Snyk:
https://app.snyk.io/org/evensol/project/5734e76a-5ebe-4fe0-9fb9-776e0cbc8504?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* fix: upgrade org.apache.logging.log4j:log4j-api from 2.21.0 to 2.21.1 (#847)

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.21.0 to 2.21.1.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-api/

See this project in Snyk:
https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* fixed minor bug in stability analysis (#844)

* Process new tp flash problem (#852)

* bug: TPflash problem

* fixed bug in flash

* comment out method

---------

Co-authored-by: Sviatoslav Eroshkin <[email protected]>

* New release (#854)

* add test (#855)

* Fix pressure bug (#856)

* add test

* fix pressure bug

* fix staility of TEG process (#859)

* improve TPflash speed (#860)

* bug fix

* update flash

* imporve flash

* improve flash in high pressure area (#862)

* improve flash

* update

* version 2.5.10 (#863)

* Update TPmultiflash.java

* Update TPmultiflash.java

* Update TPmultiflash.java

* fix error flash

* updated dynamics calc (#868)

* updated dynamics calc

* updates

* update dynamic calc

* update model

* fix test error

* remove output

* added test and fix

* update

* fixed errors control

* Release 2.5.11 (#869)

* Update pom.xml

* Update pomJava8.xml

* feat: assure no negative Ti and Td (#872)

* feat: assure no negative Ti and Td

* feat: also check for Kp
test: added tests

* fix controller (#874)

* version 2.5.12 (#875)

* Update pom.xml

* Update pomJava8.xml

* add chlorine parameters (#871)

* fix: throw exceptions in pTphaseEnvelope (#876)

* fix: upgrade org.apache.logging.log4j:log4j-api from 2.21.1 to 2.22.0 (#880)

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.21.1 to 2.22.0.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-api/

See this project in Snyk:
https://app.snyk.io/org/evensol/project/5734e76a-5ebe-4fe0-9fb9-776e0cbc8504?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* [Snyk] Upgrade org.apache.logging.log4j:log4j-core from 2.21.1 to 2.22.0 (#879)

* fix: upgrade org.apache.logging.log4j:log4j-core from 2.21.1 to 2.22.0

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-core from 2.21.1 to 2.22.0.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-core/

See this project in Snyk:
https://app.snyk.io/org/evensol/project/5734e76a-5ebe-4fe0-9fb9-776e0cbc8504?utm_source=github&utm_medium=referral&page=upgrade-pr

* fix: upgrade org.apache.logging.log4j:log4j-api from 2.21.1 to 2.22.0 (#880) (#881)

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.21.1 to 2.22.0.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-api/

See this project in Snyk:
https://app.snyk.io/org/evensol/project/5734e76a-5ebe-4fe0-9fb9-776e0cbc8504?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

---------

Co-authored-by: snyk-bot <[email protected]>

* test: add LNGship unit tests (#878)

* chore: add a security-policy (#884)

Required to stay complient for public repos in equinor. (https://developer.equinor.com/governance/scm-policy/)

* fix set lp limit (#885)

* added test for umrpru (#886)

* added test for umrpru

* updated

* update

* fix bug saturation temperature and add test

* update name

* Update src/main/java/neqsim/PVTsimulation/simulation/SaturationTemperature.java

good suggestion

Co-authored-by: Jørgen Engelsen <[email protected]>

* Update src/test/java/neqsim/PVTsimulation/simulation/SaturationTemperatureTest.java

Co-authored-by: Jørgen Engelsen <[email protected]>

* Update src/main/java/neqsim/PVTsimulation/simulation/SaturationPressure.java

Co-authored-by: Jørgen Engelsen <[email protected]>

* Update SaturationTemperature.java

* Update SaturationPressure.java

---------

Co-authored-by: Jørgen Engelsen <[email protected]>

* Update pom.xml (#888)

* Update pom.xml

* Update pomJava8.xml

* added compressor test and initial code (#877)

* added compressor test and initial code

* some more work

* some further work to get dynamic compressor to work

* strugling to find error

* improve compressor calcs

* added compressor mointor

* further work in dynamic compressors

* update

* updates

* updated

* further work

* update dynamic

* update

* update

* update

* update

* update

* update

* update

* update

* update power

* add maxminspeed setters

* check if controller is active

* removed try catch block and added check for actualFlowRateNew

* removed print to screen in test

* Update pom.xml (#889)

* Update pom.xml

* Update pomJava8.xml

* doc: fix javadoc (#891)

* doc: fix javadoc

* chore: remove non-implemented FileWriter classes (#848)

* chore: build with java 21
update dependencies and github workflows

* Update release_with_jars.yml

indentation error

* Update release_with_jars.yml

* fix: typo Update release_with_jars.yml

* fix read kij from eclipse (#892)

* fix read kij from eclipse

* fix bug

* add inflow unit (#893)

* add inflow unit

* minor updates

* updates

* update adjuster

* pdate

* update

* finalize test

* update (#894)

* version 2.5.15 (#895)

* Update pom.xml

* Update pomJava21.xml

* Update pomJava8.xml

* Update release_with_jars.yml

* fix: pipe beggs and brills y factor (#898)

* possible to calc out pressure of valve (#897)

* possible to calc out pressure of valve

* added test to pipeline flow

* remove output

* prepare version 2.5.16

* update adjuster (#900)

* update adjuster

* fix bug adjuster

* removed output added test

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update verify_build.yml

* fix: add more get methods (#902)

* feat: module class add get meas device (#903)

* fix: upgrade org.apache.logging.log4j:log4j-api from 2.22.0 to 2.22.1 (#905)

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.22.0 to 2.22.1.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-api/

See this project in Snyk:
https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* fix: upgrade org.apache.logging.log4j:log4j-core from 2.22.0 to 2.22.1 (#904)

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-core from 2.22.0 to 2.22.1.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-core/

See this project in Snyk:
https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* build(deps): sync log4j version in all poms (#906)

* update mechanical design models for scrubber (#912)

* update models

* update

* updates

* updates

* update

* update

* update

* release 2.5.17 (#913)

* release 2.5.17

* Update pomJava21.xml

* Update pomJava8.xml

* fix: upgrade org.ojalgo:ojalgo from 53.1.1 to 53.2.0 (#908)

Snyk has created this PR to upgrade org.ojalgo:ojalgo from 53.1.1 to 53.2.0.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.ojalgo/ojalgo/

See this project in Snyk:
https://app.snyk.io/org/evensol/project/5734e76a-5ebe-4fe0-9fb9-776e0cbc8504?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* fix: pipeBeggsAndBrills (#914)

* fix: pipeBeggsAndBrills

* fix: update

* fix: set default to isothermal running

* fix: update

* fix: tests

* fix: typo in ProcessModule (#915)

* Bug  mpm returns incorrect value (#917)

* bug: MPM returns incorrect value

* bug fix suggestion.

Bug had to do when we create a stream from another stream (as we do for stream2). Then we set temperature and pressure on it - but it does not set it on the correct stream

* added init properties

* bug fix

* update

* fix bug

* new fix

---------

Co-authored-by: Sviatoslav Eroshkin <[email protected]>

* refact: use const from modelsettings

* fix: rename class CalcIonicComposition

* refact: remove deprecation, simplify init

* simplify default method

* feat: do not let display throw exception

* fix

* test: disable tests not working on github

* fix

* style: whitespace (#924)

* style: whitespace

* release 2.5.18 (#925)

* refact: remove deprecated setPhaseType(int phaseToChange, int newPhaseType)

* rm:  setPhaseType(int phaseToChange, String phaseTypeName)

* refact: rm getPhaseType and setPhaseType(int phaseType)

* refact: remove deprecated functions

* refact: reorder code

* refact: replace use of phasetype as int

* doc: javadoc fix

* refact: replace integer references to phasetype

* refact: phaseType.getValue-> compare with enum type

docfix

revert

* refact: rename variables

* style

* fix: upgrade org.ojalgo:ojalgo from 53.2.0 to 53.3.0 (#931)

Snyk has created this PR to upgrade org.ojalgo:ojalgo from 53.2.0 to 53.3.0.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.ojalgo/ojalgo/

See this project in Snyk:
https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* refact: make PhaseGE abstract, throw exception for non implemented methods

* chore: move main function to test

* test: allow some numerical inaccuracy

* refact: logger error -> warn

* refact: systemthermo.initAnalytic(int type, int phase)

* refact:   public void initAnalytic(int type)

* git commit -m "refact: rename type to initType"

* refact: remove redundant method definition

* test: add tests (#936)

* test: add tests

* update tests

* Update PhasePCSAFTRahmatTest.java

* Update SystemPCSAFTTest.java

---------

Co-authored-by: Even Solbraa <[email protected]>

* docfix

* rename variables

* docfix: revert

* refact: remove redundant code

* chore: update github action versions

* refact: remove unused function input compnumber from removecomponent (#940)

* feat: simplify removeComponent
* refact: reorder methods
* docfix

* refact: Phase classes clean up (#941)

* refact: remove redundant variable definitions (#943)

* Ref rahmat 2 (#945)

* refact: remove duplicate setters/getters

* refact: remove redundant getter/setters (#946)

* fix: upgrade org.apache.logging.log4j:log4j-core from 2.22.1 to 2.23.0 (#948)

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-core from 2.22.1 to 2.23.0.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-core/

See this project in Snyk:
https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* fix: upgrade org.apache.logging.log4j:log4j-api from 2.22.1 to 2.23.0 (#947)

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.22.1 to 2.23.0.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-api/

See this project in Snyk:
https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* Update README.md (#949)

* refact: make method default in Interface (#950)

* fix: throw exception for not implemented methods (#951)

* fix: throw exception for not implemented methods

* style: alignment

* refact: simplify EOS subclass constructor

* refact: simplify super ctor calls

* refact: simplify srkeos subclass constructors

* refact: simplify preos subclass constructors

* refact: simplify SystemSrkCPA subclass constructors

* Whitespace style (#955)

* style: whitespace and comment fixes

* fix: javadoc typo (#956)

* release 2.5.19 (#958)

* refact: Eclipse cleanup (#959)

* refact: Eclipse cleanup
* style: whitespace

* chore: align pom files (#960)

* chore: align pom files
update maven references for java8

* refact: reorder methods system (#961)

* refact: reorder methods using eclipse reorder code (#963)

* feat: propertyFlash - more robust input handling  (#962)

* fix: check that fraction belongs to current component
* feat: more robust handling of input components
* feat: SystemInterface.hasComponent
* chore: release 2.5.20

* Update MultiPhaseMeter.java (#964)

remove output in MPM

* fix: bugfixes Phase.addComponent (#966)

* Update verify_build.yml

* Create publish_javadoc.yml

* feat: Phase.hasComponent check against normalized name (#965)

feat: Phase.hasComponent check against normalized name
feat: new function Phase.getComponentNames
fix: check that compnumber is valid and not in use (previously possible to overwrite component in array)
docfix

* Update verify_build.yml

* fix: more robust propertyFlash (#967)

* phaseType fix (#969)

* v2.5.21 (#970)

* Update pom.xml

* Update pomJava8.xml

* Update pomJava21.xml

* fix: upgrade org.apache.logging.log4j:log4j-core from 2.23.0 to 2.23.1 (#972)

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-core from 2.23.0 to 2.23.1.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-core/

See this project in Snyk:
https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* fix: upgrade org.apache.logging.log4j:log4j-api from 2.23.0 to 2.23.1 (#973)

Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.23.0 to 2.23.1.

See this package in Maven Repository:
https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-api/

See this project in Snyk:
https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* fix solid flash (#975)

* fix solid calcs (#976)

* fix solid flash

* update

* update

* update

* add chack for component in temp database

* remove output

* prepare for version 2.5.22 (#977)

* fix: update devcontainer.json to new format (#978)

* fix: update devcontainer.json to new format
chore: update checkstyle version
style: fix xml and json tab settings
* chore: checkstyle, match default import order

* add alkene components (#981)

* add ethylene

* update components

* added pHFlash Test for CPA (#982)

* Add more units (#983)

* add psi and psig units

* add common unit specification

* added test for temperatures (#984)

* added more field units (#985)

* added more field units

* more updates to units

* more field units

* add possibility to see available units

* fix test for units

* update text

* update

* first implementation of reporting of process (#986)

* first implementation of reporting of process

* added json reporting

* fixed bug in stream

* update pom

* update doc

* fix bug

* update

* update

* update

* 987 do not converge recycles at each process simulation (#989)

* first test

* update run step

* added Value as response (#988)

* added Value as response

* added json report from process object

* update

* update

* fix error.

* added tests for saturation calculations (#991)

* improve json properties (#990)

* inproved properties

* further updates

* update barrels/day

* add wt fraction

* updated method

* added RVP and TVP methods (#992)

* Update Standard_ASTM_D6377Test.java

* bug fix json stream (#994)

* initial test rachford rice (#995)

* initial test rachford rice

* update rachford rice - moved to separate class

* modified rachford rice implementation

* added Rachford rice tests

* new implementation rachford rice (#996)

* new implementation rachford rice

* update tests

* update

* update method doc

* update

* Update StreamResponse.java

* update response

* add GCV and WI for streams (#997)

* added GCV/WI to stream response (#998)

* Update StreamResponse.java

* update Sm3hr unit

* added response

* improved speed of water saturator (#999)

* fix report (#1000)

* updated diff lib simulation and test (#1001)

* updated diff lib simulation and test

* update

* update CME

* update

* fix Eclipse update (#1003)

* remove gitlens from devcontainer (#1004)

* update eclipse read (#1005)

* update eclipse reader (#1006)

* release 2.5.23 (#1007)

* update units (#1008)

* Units-upd (#1009)

* update units

* update

* added exceptions for units not supported (#1010)

* added exceptions for units not supported

* typo fix

* work on units

* update tests

* added unit

* test for metric units

* update units

* added fluid report

* removed output in json fluid and stream

* update respons

* Update FluidResponse.java

* Update FluidResponse.java

* added pure component properties in json

* added more parameters to json

* update

* update process simulation with run in step (#1011)

* update process simulation with run in step

* update run step

* update test for run in steps

* update test for step process

* version 2.5.24 Update pom.xml (#1012)

* version 2.5.25 Update pom.xml

* Update pomJava21.xml

* Update pomJava8.xml

* added Cp, Cv, enthalpy, entropy (#1013)

* update josn report format (#1014)

* added Zvol corr (#1015)

* Update SystemThermo.java

* update json reporting (#1016)

* update json reporting

* update test

* added unit for temperature (#1017)

* version 2.5.25 (#1019)

* update test (#1020)

* update test

* fixed bug

* update

* update (#1021)

* fix bug change composition to all phases (#1022)

* cvd and multiphase corrections for reservoir (#1023)

* cvdfor reservoir

* added some implementation of TPflash reservoir

* update

* fix error in simulation

* update

* update init(0)

* start adding MPFM fitter

* fix: upgrade com.google.code.gson:gson from 2.10.1 to 2.11.0 (#1024)

Snyk has created this PR to upgrade com.google.code.gson:gson from 2.10.1 to 2.11.0.

See this package in maven:
com.google.code.gson:gson

See this project in Snyk:
https://app.snyk.io/org/evensol/project/5734e76a-5ebe-4fe0-9fb9-776e0cbc8504?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* added test (#1026)

* Flow Induced Vibrations  (#1025)

* feat: LOF calc

---------

Co-authored-by: Even Solbraa <[email protected]>

* fix bug separator inlet stream

* update version (#1027)

* Update release_with_jars.yml

* try fix (#1029)

* try fix

* update

* fix: but with str units (#1028)

* fix: bug with Oil Test increase (#1032)

* fix: flow induced vibrations (#1031)

* version 2.5.27 (#1033)

* mior update logger floe rate adjuster (#1035)

* mior update logger floe rate adjuster

* minor updates

* fix json error on report (#1034)

* add temperature dependent volume correction for gas (#1036)

* add temperature dependent volume correction for gas

* Update Density.java

* Update Density.java

* fix: oil sep bug (#1037)

* fix: oil sep bug

* commented out failed test

* removed feiling test oilProcessTest

* rachford rice cleanup

---------

Co-authored-by: Even Solbraa <[email protected]>

* version 2.5.28 (#1038)

* Update Units.java

* add set and get methods and a test (#1039)

* Update Splitter.java (#1043)

* Update Splitter.java

get  split factor values

* Update Splitter.java

* remove unhandeled runtime exception (#1042)

* remove unhandeled runtime exception

* added possibility to chenge method used in Rachford RIce

* update

* Update PhaseEos.java

* add vol correction test (#1041)

* feat: update flow rate adjuster (#1044)

* fix: flow rate adjuster phases (#1045)

* 2.5.29 (#1046)

* Cv method valves (#1047)

* Cv method valves

* added Cv for liquids

* update formulaes

* update

* sstill something wrong here...

* fixed error

* update RVP calc (#1048)

* Rvpupdate2 (#1049)

* Cv method valves

* added Cv for liquids

* update formulaes

* update

* sstill something wrong here...

* fixed error

* update RVP calc

* update 2

* update

* improved TVflash (#1051)

* Fix-failed-SimpleReservoirTest.testRun (#1052)

* improved TVflash

* fixed bug TVflash

* Update TVflash.java

* RVP fix

* added more methods (#1053)

* fix: upgrade org.jfree:jfreechart from 1.5.4 to 1.5.5 (#1054)

Snyk has created this PR to upgrade org.jfree:jfreechart from 1.5.4 to 1.5.5.

See this package in maven:
org.jfree:jfreechart

See this project in Snyk:
https://app.snyk.io/org/evensol/project/5734e76a-5ebe-4fe0-9fb9-776e0cbc8504?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>

* fix: HEX (#1055)

* version 2.5.30 (#1056)

* fixed bug in json HX response (#1058)

* work ongoing

* fixed NaN in HX response

* added duty in output

* changed variable name

* added pump output (#1060)

* use key overall in stream and fluid response (#1061)

* added set pressure with unit (#1062)

* doc: fix javadoc @link to type double causing javadoc warnings (#1057)

* doc: fix javadoc link

* chore: update maven plugins, require maven version 3.8.8 and java 8 (#1064)

* chore: update maven plugins

* chore: fix javadoc (#1066)

* chore: fix javadoc (#1067)

* chore: fix javadoc

* feat: publish releases to maven central (#1068)

* chore: release v2.5.31 (#1069)

* Update maven_publish.yml

* Update maven_publish.yml

* upgrade H2 db (#1070)

* upgrade H2 db

* Update pomJava21.xml

* 1063 add delta t specification for heat exchangers (#1071)

* first version

* update delta T with HX

* update delta T HX

* chore: add checkstyle plugin (#1072)

remove unused/outdated parameters

* test a new method for phase envelope calculation (#1074)

* test a new method for phase envelope calculation

* update test

* further improvements

* update model

* update

* update

* added one test

* update method name to calcPTphaseEnvelope2

* updated method name in test

---------

Co-authored-by: Åsmund Våge Fannemel <[email protected]>

* chore: fixed warnings (#1073)

* chore: fixed warnings

* start adding more fluid property models (#1075)

* start adding more fluid property models

* add java test to sdcode

* further implementation

* futher updates on Twu model

* updated test

* added PC, TC and VC

* fix bug in PC calculation for oil components and all tests (#1076)

* fix bug in PC calculation for oil components and all tests

* fix slim tube test

* change default phase envelope algorithm (#1077)

* change default phase envelope algorithm

* update errors

* updated to version 2.5.32

* fix errors

* update calc PT envelope

* update phaseenvelope tests

* added test for Plus fraction model (#1079)

---------

Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: Sviatoslav Eroshkin <[email protected]>
Co-authored-by: Åsmund Våge Fannemel <[email protected]>
Co-authored-by: Jørgen Engelsen <[email protected]>
Co-authored-by: Åsmund Våge Fannemel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvenSol EvenSol EvenSol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asmfstatoil @codecov-commenter @EvenSol