Fix option to add rhel8 releases #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsevj
force-pushed
the
add_option_to_add_rhel8_releases
branch
from
03912f4 to
bc55995
Compare
andreas-el
reviewed
Apr 22, 2024
komodo/insert_proposals.py
Outdated
| @@ -209,7 +209,7 @@ def create_pr_with_changes( | |||
| pr_msg: str, | |||
| rhel8: Optional[bool] = False, | |||
| ): | |||
| commit_title = f"Add release {target}+rhel8" if rhel8 else f"Add release {target}" | |||
| commit_title = f"Add release {target} +rhel8" if rhel8 else f"Add release {target}" | |||
There was a problem hiding this comment.
I think version numbers should have no spaces in them.
Can you consider using cut or other tools to extract the version number?
E.g.
COMMIT_MESSAGE="Add release 2024.02.04+rhel200"
release_name=$(echo $COMMIT_MESSAGE | rev | cut -d ' ' -f 1 | rev) # remove: Add release
release_name=$(echo $release_name | cut -d + -f 1) # remove: +rhel
echo $release_name
There was a problem hiding this comment.
But +rhel8 is not a part of the version number, it is simply an identifier in the commit header saying that one should build for rhel8?
larsevj
force-pushed
the
add_option_to_add_rhel8_releases
branch
from
bc55995 to
88d031d
Compare
larsevj
force-pushed
the
add_option_to_add_rhel8_releases
branch
from
88d031d to
a98dfe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.