Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arguments to transpile #315

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Add arguments to transpile #315

merged 1 commit into from
Mar 8, 2023

Conversation

hnformentin
Copy link
Contributor

Solves #308

@hnformentin hnformentin marked this pull request as draft January 19, 2023 08:41
@hnformentin hnformentin linked an issue Jan 19, 2023 that may be closed by this pull request
Add arguments for komodo-transpiler #308
Closed
@hnformentin hnformentin force-pushed the transpile_add_arguments branch 2 times, most recently from 6771eef to cc35f70 Compare January 24, 2023 14:28
@hnformentin hnformentin force-pushed the transpile_add_arguments branch 2 times, most recently from a44652f to 78b171b Compare February 2, 2023 09:12
@hnformentin hnformentin marked this pull request as ready for review February 2, 2023 09:22
kwinkunks
kwinkunks reviewed Feb 2, 2023
View reviewed changes
komodo/matrix.py Outdated Show resolved Hide resolved
@hnformentin hnformentin force-pushed the transpile_add_arguments branch from 78b171b to f5da2e2 Compare February 2, 2023 14:47
@hnformentin

This comment was marked as outdated.

Sign in to view
@hnformentin hnformentin force-pushed the transpile_add_arguments branch from c8b72af to 4c83f86 Compare February 3, 2023 08:35
kwinkunks
kwinkunks previously requested changes Feb 6, 2023
View reviewed changes
komodo/release_transpiler.py Outdated Show resolved Hide resolved
komodo/build.py Outdated Show resolved Hide resolved
komodo/release_transpiler.py Outdated Show resolved Hide resolved
@hnformentin hnformentin force-pushed the transpile_add_arguments branch from 4c83f86 to 04b98e7 Compare February 6, 2023 08:31
@hnformentin hnformentin requested a review from kwinkunks February 6, 2023 08:52
@kwinkunks

This comment was marked as resolved.

Sign in to view
@hnformentin hnformentin force-pushed the transpile_add_arguments branch from eb10452 to 0c23e43 Compare February 10, 2023 13:28
@hnformentin

This comment was marked as outdated.

Sign in to view
@hnformentin

This comment was marked as resolved.

Sign in to view
@hnformentin hnformentin force-pushed the transpile_add_arguments branch from 0c23e43 to b8a6f8a Compare February 17, 2023 09:37
@hnformentin

This comment was marked as outdated.

Sign in to view
@kwinkunks kwinkunks mentioned this pull request Feb 21, 2023
Merged
@hnformentin hnformentin force-pushed the transpile_add_arguments branch from b8a6f8a to c24d4ea Compare February 22, 2023 14:07
@kwinkunks

This comment was marked as outdated.

Sign in to view
@hnformentin hnformentin mentioned this pull request Feb 28, 2023
Open
@hnformentin hnformentin force-pushed the transpile_add_arguments branch from 70e42bd to 8fc7ade Compare February 28, 2023 09:15
@hnformentin

This comment was marked as resolved.

Sign in to view
valentin-krasontovitsch

This comment was marked as resolved.

Sign in to view

@hnformentin hnformentin force-pushed the transpile_add_arguments branch 2 times, most recently from 3f0c518 to fee61a3 Compare March 6, 2023 14:15
hnformentin
hnformentin commented Mar 6, 2023
View reviewed changes
Copy link
Contributor Author

@hnformentin hnformentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes and corresponding replies so far!

tests/test_release_transpiler.py Show resolved Hide resolved
tests/test_release_transpiler.py Outdated Show resolved Hide resolved
komodo/release_transpiler.py Outdated Show resolved Hide resolved
komodo/release_transpiler.py Show resolved Hide resolved
@hnformentin hnformentin force-pushed the transpile_add_arguments branch from 5801e69 to 5f5a318 Compare March 8, 2023 13:17
@hnformentin
Add argument --coords for defining rhel and py versions to build in a…
9e542cc 
… release matrix

The arguments are optional and the default is python 3.8 and rhel 7.
@hnformentin hnformentin force-pushed the transpile_add_arguments branch from 5f5a318 to 9e542cc Compare March 8, 2023 13:26
@hnformentin
Copy link
Contributor Author

This changes small changes after approval were made after discussion with the reviewer 🚀

@hnformentin hnformentin dismissed kwinkunks’s stale review March 8, 2023 13:29

Matt passed the ball to Valentin.

@hnformentin hnformentin merged commit 9a77c1f into equinor:main Mar 8, 2023
@hnformentin hnformentin deleted the transpile_add_arguments branch March 8, 2023 13:29
@hnformentin hnformentin self-assigned this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentin-krasontovitsch valentin-krasontovitsch valentin-krasontovitsch approved these changes

@kwinkunks kwinkunks Awaiting requested review from kwinkunks

Assignees

@hnformentin hnformentin

Labels
build-pipeline tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add arguments for komodo-transpiler
3 participants
@hnformentin @kwinkunks @valentin-krasontovitsch