Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give generate_media_config optional return type #671

Merged
merged 1 commit into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/robot_interface/models/mission/task.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from dataclasses import dataclass, field
from enum import Enum
from typing import Iterator, Literal, Optional, Type, Union
from typing import Literal, Optional, Type, Union

from alitra import Pose, Position

Expand Down
4 changes: 2 additions & 2 deletions src/robot_interface/robot_interface.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from abc import ABCMeta, abstractmethod
from queue import Queue
from threading import Thread
from typing import Callable, List
from typing import Callable, List, Optional

from robot_interface.models.robots.media import MediaConfig
from robot_interface.models.initialize import InitializeParams
Expand Down Expand Up @@ -226,7 +226,7 @@ def initialize(self, params: InitializeParams) -> None:
raise NotImplementedError

@abstractmethod
def generate_media_config(self) -> MediaConfig:
def generate_media_config(self) -> Optional[MediaConfig]:
"""
Generate a JSON containing the url and token needed to establish a media stream
connection to a robot.
Expand Down
Loading