Pass on task zoom value from API #666
Conversation
andchiind
force-pushed
the
custom-zoom
branch
2 times, most recently
from
2e98402 to
baae77f
Compare
| class ZoomDescription: | ||
| width: float | ||
| height: float |
There was a problem hiding this comment.
Since the values are height and width of inspection object it might be more descriptive to rename to something like ObjectSize/InspectionTargetSize?
There was a problem hiding this comment.
Agree with @Eddasol, InspectionTargetSize or InspectionTargetProperties
There was a problem hiding this comment.
I compromised and made it clear that the width and height refer to the width and height of the object, while keeping it in a "zoom" context, since it is not the general width and height of the object, but the width and height from the point of view of the robot when taking a photo. This could otherwise create some confusion imo. We for instance do not provide a depth, so it is not a complete description of the inspection target.
There was a problem hiding this comment.
But if we end up adding more metadata for the inspection action then we can also generalise this class.
There was a problem hiding this comment.
We are not also necessarily describing the objects' width and height but just the width and height of the target in the image. For a fence for instance, we are not stating that the provided values are the width and height of the fence. It is a value specific to zoom.
andchiind
force-pushed
the
custom-zoom
branch
from
baae77f to
81ebc73
Compare
No description provided.