Let ISAR generate mission.id, task.id and inspection.id #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsundvoll
force-pushed
the
set-task-inspection-id
branch
from
c2fd084 to
8f88f5a
Compare
tsundvoll
force-pushed
the
set-task-inspection-id
branch
from
8f88f5a to
366e000
Compare
oysand
reviewed
Dec 11, 2024
oysand
reviewed
Dec 11, 2024
oysand
reviewed
Dec 11, 2024
tsundvoll
force-pushed
the
set-task-inspection-id
branch
from
366e000 to
cfd86f4
Compare
for mission, task and inspection. Therefore the ids are removed from the StartMissionDefinitions and instead generated when the Mission and Tasks are created Some refactors are also applied, most notably replacing dataclass with pydantic BaseModels
tsundvoll
force-pushed
the
set-task-inspection-id
branch
from
cfd86f4 to
2fbe3bc
Compare
tsundvoll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.