Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ObstacleStatus and RobotStatus #491

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

UsamaEquinorAFK
Copy link

No description provided.

main.py Outdated Show resolved Hide resolved
oysand
oysand previously requested changes Oct 9, 2023
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@UsamaEquinorAFK UsamaEquinorAFK force-pushed the rs branch 3 times, most recently from 8d4c1d3 to 7d3ebe4 Compare October 24, 2023 13:59
@UsamaEquinorAFK UsamaEquinorAFK force-pushed the rs branch 2 times, most recently from bdacfbf to f94deab Compare October 31, 2023 08:09
@UsamaEquinorAFK UsamaEquinorAFK marked this pull request as ready for review October 31, 2023 12:54
@UsamaEquinorAFK UsamaEquinorAFK dismissed oysand’s stale review October 31, 2023 12:55

Dismissing and getting it reviewed by Anders

main.py Outdated
mqtt_client: MqttClient = MqttClient(mqtt_queue=queues.mqtt_queue)

mqtt_thread: Thread = Thread(
target=mqtt_client.run, name="ISAR MQTT Client", daemon=True
)
threads.append(mqtt_thread)

print("Seeing up robot status publisher now")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be "Setting"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be there

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed now

Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UsamaEquinorAFK UsamaEquinorAFK merged commit 4cc26c4 into equinor:main Oct 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants