-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(framework-cli): Update bookmark module to use provided provider
This commit updates the bookmark module to use the provided bookmark provider. The `BookmarkProvider` component now requires the provider as a parameter and shares the context of the provided provider to its child components. The deprecated hook has been removed, and the component has been updated to align with the changes in the modules. BREAKING CHANGES: The `BookmarkProvider` now requires the provider as a parameter.
- Loading branch information
Showing
4 changed files
with
50 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
'@equinor/fusion-framework-cli': minor | ||
--- | ||
|
||
Updated Bookmark Integration in Dev Portal | ||
|
||
- **Refactored `BookMarkSideSheet.tsx`:** | ||
|
||
- Replaced `useHasBookmark` with `useCurrentAppModule<BookmarkModule>('bookmark')` for better module integration. | ||
- Updated button `disabled` state to use `bookmarkProvider?.hasBookmarkCreators`. | ||
|
||
- **Updated `Header.tsx`:** | ||
|
||
- Added `useCurrentAppModule<BookmarkModule>('bookmark')` to manage bookmark module state. | ||
- Disabled bookmark button if `bookmarkProvider` is not available. | ||
- Passed `bookmarkProvider` to `BookmarkProvider` component. | ||
|
||
- **Configuration Changes in `config.ts`:** | ||
- Switched import from `@equinor/fusion-framework-module-bookmark` to `@equinor/fusion-framework-react-module-bookmark`. | ||
- Added `builder.setFilter('application', true)` to bookmark configuration. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters