Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(summary): Add Task Owner Report endpoints #711

Merged
merged 18 commits into from
Nov 6, 2024

Conversation

Jonathanio123
Copy link
Collaborator

@Jonathanio123 Jonathanio123 commented Oct 22, 2024

  • New feature
  • Bug fix
  • High impact

Description of work:

AB#57125

  • Adds necessary endpoints for task owner reports. This includes get and put for projects and task owner reports
  • Removed personIdentifiers validation as I believe it is not the summary apis responsibility to verify this. In the case there is an invalid person, then the whole put request errors out. This in turn may lead to an entire project or department not reviving a report.

Code is quite simple, but there is a lot of boilerplate code that needs to be written

Testing:

  • Can be tested
  • Automatic tests created / updated
  • Local tests are passing

Written simple tests. Api does nothing by itself and a larger test will be conducted once azure functions are up and running

Checklist:

  • Considered automated tests
  • Considered updating specification / documentation
  • Considered work items
  • Considered security
  • Performed developer testing
  • Checklist finalized / ready for review

@Jonathanio123 Jonathanio123 force-pushed the feat/summary/task-owner-report branch from 18e54a9 to 4ded630 Compare October 22, 2024 14:16
@Jonathanio123 Jonathanio123 changed the title Feat/summary/task owner report feat(summar): Add Task Owner Report endpoints Oct 23, 2024
@Jonathanio123 Jonathanio123 changed the title feat(summar): Add Task Owner Report endpoints feat(summary): Add Task Owner Report endpoints Oct 23, 2024
@Jonathanio123 Jonathanio123 marked this pull request as ready for review October 29, 2024 11:35
Jonathanio123 added a commit that referenced this pull request Nov 6, 2024
- [x] New feature
- [ ] Bug fix
- [ ] High impact

**Description of work:**
<!--- Please give a description of the work --->


[AB#57449](https://statoil-proview.visualstudio.com/787035c2-8cf2-4d73-a83e-bb0e6d937eec/_workitems/edit/57449)

Similar to the resource owners sync function, this retrieves recipients
(admins and project director) and project data from org api. Then stores
it in the Summary api and sends it to the queue to be processed by a
worker.

- Only projects that are active are synced
- Only projects that have an active project director or have any direct
admins will be synced.

**Testing:**
- [x] Can be tested
- [ ] Automatic tests created / updated
- [x] Local tests are passing

<!--- Please give a description of how this can be tested --->

I've ran this locally and in azure pr env against this other PR env:
#711

Will run infra pipeline to create pr/ci/fqa queues and az funcs when
this has been code reviewed. Done!

**Checklist:**
- [x] Considered automated tests
- [x] Considered updating specification / documentation
- [x] Considered work items 
- [x] Considered security
- [x] Performed developer testing
- [x] Checklist finalized / ready for review

<!--- Other comments --->
@Jonathanio123 Jonathanio123 merged commit ba60cda into master Nov 6, 2024
11 checks passed
@Jonathanio123 Jonathanio123 deleted the feat/summary/task-owner-report branch November 6, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants