Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose x-trace-id in response headers #708

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

edmondbaloku
Copy link
Contributor

  • New feature
  • Bug fix
  • High impact

Description of work:
Frontend are showing the x-trace-id available from response headers in a api request, but as the resources and summary services did not expose the x-trace-id it was shown as null.

AB#56897

Testing:

  • Can be tested
  • Automatic tests created / updated
  • Local tests are passing

Can be tested manually by looking at the response headers from any requests to the resources or summary api (absence request on landing page) and verifying that x-trace-id is under the access-control-expose-headers like this

access-control-expose-headers: Allow,x-fusion-retriable,x-trace-id

Checklist:

  • Considered automated tests
  • Considered updating specification / documentation
  • Considered work items
  • Considered security
  • Performed developer testing
  • Checklist finalized / ready for review

@edmondbaloku edmondbaloku merged commit 921a1d3 into master Oct 15, 2024
13 checks passed
@edmondbaloku edmondbaloku deleted the chore/expose-x-trace-id branch October 15, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants