Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(resources): Archive DelegatedResourceOwners when org unit is deleted #697

Merged

Conversation

Jonathanio123
Copy link
Collaborator

@Jonathanio123 Jonathanio123 commented Sep 6, 2024

  • New feature
  • Bug fix
  • High impact

Description of work:
AB#55599

  • Adds the command ArchiveDelegatedResourceOwners that archives and removes roles of the specified delegated resource owners

  • Adds a new event handler for when an org unit is deleted which calls the new command

Testing:

  • Can be tested
  • Automatic tests created / updated
  • Local tests are passing

Wrote a unit test for the command. Tested by creating and executing a temporary admin endpoint which calls the archive command.

Checklist:

  • Considered automated tests
  • Considered updating specification / documentation
  • Considered work items
  • Considered security
  • Performed developer testing
  • Checklist finalized / ready for review

@Jonathanio123 Jonathanio123 force-pushed the chore/resources/cleanup-delegated-owners-on-org-deleted branch from 5746a13 to b896ffc Compare September 6, 2024 08:40
@Jonathanio123 Jonathanio123 changed the title chore(resources): Archive DelegatedResourceOwners when org unit deleted chore(resources): Archive DelegatedResourceOwners when org unit is deleted Sep 6, 2024
@Jonathanio123 Jonathanio123 marked this pull request as ready for review September 6, 2024 09:03
@Jonathanio123 Jonathanio123 requested a review from larfeq September 9, 2024 14:16
@larfeq larfeq requested a review from aleklundeq September 11, 2024 06:50
@Jonathanio123 Jonathanio123 merged commit 7a6a86d into master Sep 13, 2024
11 checks passed
@Jonathanio123 Jonathanio123 deleted the chore/resources/cleanup-delegated-owners-on-org-deleted branch September 13, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants