Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter out product positions from GetPersonnelAllocation #686

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

aleklundeq
Copy link
Collaborator

@aleklundeq aleklundeq commented Sep 2, 2024

  • New feature
  • Bug fix
  • High impact

Description of work:
We don't want product positions (instances) to show up in the list over all allocations in Personnel Allocation, and therefore we need to filter out all these positions.

AB#55286
AB#53017

Testing:

  • Can be tested
  • Automatic tests created / updated
  • Local tests are passing

Can be tested with using endpoint:
https://resources-api-pr-686.fusion-dev.net/departments/{departmentString}/resources/personnel/{personId}?api-version=1.0

Change departmentString with the department you want to check and change personId to a person you want to check. Example "PDP PRD PMC PCA PCA4".
There should be several persons with product positions assigned to them, but these should not be shown when searching for them here.

Should get all other positions for personnel.

Checklist:

  • Considered automated tests
  • Considered updating specification / documentation
  • Considered work items
  • Considered security
  • Performed developer testing
  • Checklist finalized / ready for review

@aleklundeq aleklundeq merged commit 3fb6778 into master Sep 2, 2024
11 checks passed
@aleklundeq aleklundeq deleted the feat/filter-out-product-position-more branch September 2, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants