-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Summary report email layout #676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larfeq
approved these changes
Aug 22, 2024
larfeq
approved these changes
Aug 23, 2024
# Conflicts: # src/Fusion.Summary.Functions/Functions/WeeklyDepartmentSummarySender.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
AB#54653
This PR rewrites the adaptive card code to make it look better. It also adds personnel-allocation app key to the notifcation. This means that if core adds a toggle for personnel allocation, then emails can be turned of for the app. https://github.com/equinor/fusion/issues/390
If we want to perfect the mail design then I believe we'll need to create a separate message and manually send it to the mail service. As I couldn't get the list values to show properly and I couldn't find a way to center the action button. See US https://statoil-proview.visualstudio.com/Fusion%20Resource%20Allocation/_workitems/edit/55681
New design:
Old design:
Testing:
Checklist: