Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Summary report email layout #676

Merged
merged 16 commits into from
Sep 2, 2024

Conversation

Jonathanio123
Copy link
Collaborator

@Jonathanio123 Jonathanio123 commented Aug 22, 2024

  • New feature
  • Bug fix
  • High impact

Description of work:

AB#54653

This PR rewrites the adaptive card code to make it look better. It also adds personnel-allocation app key to the notifcation. This means that if core adds a toggle for personnel allocation, then emails can be turned of for the app. https://github.com/equinor/fusion/issues/390

If we want to perfect the mail design then I believe we'll need to create a separate message and manually send it to the mail service. As I couldn't get the list values to show properly and I couldn't find a way to center the action button. See US https://statoil-proview.visualstudio.com/Fusion%20Resource%20Allocation/_workitems/edit/55681

New design:
image

Old design:
image

Testing:

  • Can be tested
  • Automatic tests created / updated
  • Local tests are passing

Checklist:

  • Considered automated tests
  • Considered updating specification / documentation
  • Considered work items
  • Considered security
  • Performed developer testing
  • Checklist finalized / ready for review

@Jonathanio123 Jonathanio123 marked this pull request as ready for review August 22, 2024 09:00
@Jonathanio123 Jonathanio123 merged commit 5e20d0f into master Sep 2, 2024
13 checks passed
@Jonathanio123 Jonathanio123 deleted the chore/summary/adjust-notification-card branch September 2, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants