Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Drop Python 3.8 support #267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 5 additions & 25 deletions .github/workflows/fmu-tools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,34 +19,14 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
# 1.1.3 for Python 3.8 in RMS up to 14.2
# 1.5.3 for Komodo
pandas-version: ["1.1.3", "1.5.3", "2.0.2", "2.*"]
python-version: ["3.9", "3.10", "3.11", "3.12"]
# 2.0.2 for RMS 14.2+, 2.* for Komodo
pandas-version: ["2.0.2", "2.*"]
exclude:
- python-version: "3.12"
pandas-version: "1.1.3"
- python-version: "3.12"
pandas-version: "1.5.3"
# No built wheel released for 2.0.2
# No built wheel for Python 3.12
- python-version: "3.12"
pandas-version: "2.0.2"

- python-version: "3.11"
pandas-version: "1.1.3"
- python-version: "3.11"
pandas-version: "1.5.3"

- python-version: "3.10"
pandas-version: "1.1.3"
- python-version: "3.10"
pandas-version: "1.5.3"

- python-version: "3.9"
pandas-version: "1.1.3"
- python-version: "3.9"
pandas-version: "1.5.3"

steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -100,7 +80,7 @@ jobs:
- name: Update GitHub pages
if: |
github.repository_owner == 'equinor' && github.ref == 'refs/heads/main' &&
matrix.python-version == '3.8' && matrix.pandas-version == '1.1.3'
matrix.python-version == '3.11' && matrix.pandas-version == '2.0.2'
run: |
cp -R ./build/docs/html ../html
git config --local user.email "fmu-tools-github-action"
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,4 @@ target/
.projectile
.vscode
src/fmu/tools/version.py
.venv/
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ In addition:
- Start with documentation and tests. Think, design and communicate first!
- Docstrings shall start and end with """ and use Google style.
- Use pytest as testing engine
- Code shall be Python 3.8 + compliant
- Code shall be Python 3.9+ compliant


### Linting
Expand Down
30 changes: 16 additions & 14 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ write_to = "src/fmu/tools/version.py"
name = "fmu-tools"
description = "Library for various tools and scripts within Fast Model Update"
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
license = { file = "LICENSE" }
authors = [
{ name = "Equinor", email = "[email protected]" },
Expand All @@ -26,7 +26,6 @@ classifiers = [
"Topic :: Software Development :: Libraries",
"Topic :: Utilities",
"Operating System :: POSIX :: Linux",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down Expand Up @@ -87,18 +86,21 @@ ignore = [
"C901",
]
select = [
"C",
"E",
"F",
"I",
"PIE",
"Q",
"RET",
"RSE",
"SIM",
"TCH",
"TID",
"W",
# "B", # flake-8-bugbear
"C", # pylint-convention
"E", # pycodestyle-error
"F", # pyflakes
"I", # isort
"NPY", # numpy
"PIE", # flake8-pie
"Q", # flake8-quotes
"RET", # flake8-return
"RSE", # flake8-raise
"SIM", # flake8-simplify
"TCH", # flake8-type-checking
"TID", # flake8-tidy-imports
# "UP", # pyupgrade
"W", # pylint-warnings
]

[tool.ruff.lint.isort]
Expand Down
Loading