Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update README and fix filtering on bool properties #252

Merged
merged 1 commit into from
Nov 2, 2023
Merged

update README and fix filtering on bool properties #252

merged 1 commit into from
Nov 2, 2023

Conversation

equinor-ruaj
Copy link
Contributor

Fixes #248

  • Update README example code to work "out of the box"
  • Fix filtering of bool properties. Probably possible to do it more elegantly...

@equinor-ruaj equinor-ruaj requested a review from a team November 2, 2023 08:58
rwiker
rwiker approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@rwiker rwiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@equinor-ruaj equinor-ruaj merged commit 114ccbf into main Nov 2, 2023
13 checks passed
@equinor-ruaj equinor-ruaj deleted the update-readme branch November 2, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwiker rwiker rwiker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update readme examples
2 participants
@equinor-ruaj @rwiker