Do not even try to upload sesimic data that does not have data.vertical_domain #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perolavsvendsen
requested changes
Nov 22, 2024
rwiker
force-pushed
the
feature/extra-validation-for-cubes
branch
from
b6ef9b5 to
4d5ad5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seismic data (seismic cubes) are converted into OpenVDS format and uploaded into a dedicated storage account. The conversion process needs information about the data; specifically, the value of
data.vertical_domainshould be eitherdepthortime, and thesample_unitparameter of the conversion command is then accordingly set to eitherm(metres) orms(milliseconds).If
data.vertical_domainis missing (or set to something other thandepthortime) we cannot perform the conversion into OpenVDS, and we do not try to upload the object.