Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass config_path to uploader #97

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

equinor-ruaj
Copy link
Contributor

@equinor-ruaj equinor-ruaj commented Sep 20, 2024

Tests will fail until equinor/fmu-sumo-uploader#89 is merged.

@equinor-ruaj equinor-ruaj requested a review from a team September 20, 2024 08:04
@perolavsvendsen
Copy link
Member

I don't understand how the config_path argument actually makes it from the SIM2SUMO forward model job and to the uploader. I see it coming in as an argument, i.e. to args.config_path but I cannot see it going from there into the call to fmu-sumo-uploader 🤷‍♂️

@equinor-ruaj
Copy link
Contributor Author

I don't understand how the config_path argument actually makes it from the SIM2SUMO forward model job and to the uploader. I see it coming in as an argument, i.e. to args.config_path but I cannot see it going from there into the call to fmu-sumo-uploader 🤷‍♂️

The change in main.py passes the config_path to a Dispatcher(one_datafile, args.env, config_path=args.config_path)
This is stored as self._config_path which is used in _upload()
_upload() is used internally by sim2sumo (the Dispatcher) either when enough files have been add()ed or when finish() is called.

Copy link
Member

@perolavsvendsen perolavsvendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤷‍♂️

@equinor-ruaj equinor-ruaj merged commit dcdf7b5 into main Sep 20, 2024
6 checks passed
@equinor-ruaj equinor-ruaj deleted the bugfix/global-variables-path-not-used branch September 20, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants