Emulate ERT/FMU runtime #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
There was a problem hiding this comment.
Not sure I'm fully on board with adding this as part of the main script.
For us as Sumo, if we do not want users to manually upload data, then I think --emulate-ert should be moved to a separate tool. Could still be in the same repo, but not a direct part of sim2sumo.
daniel-sol
reviewed
Mar 4, 2024
There was a problem hiding this comment.
I at least partially agree with @equinor-ruaj's comment, but end of the day it depends on two things:
- There are situations when a developer might want to run sim2sumo without ert, how should that be run without too much fuss?
- Are there situations when the nightly testing that we are running/want to run need some sort of functionality like this. What is required in such a situation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible solution to #41
Adding a development option/tool that emulates ERT, by setting key environment variables.
sim2sumoruns as a subprocess of an FMU workflow, invoked by ERT. ERT sets some key environment variables, whichfmu-dataio(and potentially others) use to determine if context is FMU runtime or not. This feature enables a developer to recreate the same environment during development, i.e. when invokingsim2sumodirectly from the command line.The feature is invoked with the
--emulate_ertflag.(Also fixed some typos.)