Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Replace column strings with enums in inplace_volumes #936

Merged
merged 1 commit into from
Dec 19, 2024
Merged

MAINT: Replace column strings with enums in inplace_volumes #936

merged 1 commit into from
Dec 19, 2024

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Dec 19, 2024

PR to replace some strings in the inplace_volumes with enum values instead.

@tnatt tnatt requested a review from mferrera December 19, 2024 09:28
mferrera
mferrera approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. This is all feeling more and more standardized-y. Suggest privating the localized enums, though, just as cover

src/fmu/dataio/export/rms/inplace_volumes.py Outdated Show resolved Hide resolved
@tnatt tnatt force-pushed the update_with_enums branch from 2950512 to c2186d3 Compare December 19, 2024 12:26
@tnatt tnatt merged commit 7e8d4e0 into equinor:main Dec 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mferrera mferrera mferrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnatt @mferrera