ENH: Add required volume calculations #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnatt
force-pushed
the
require_volumetrics_columns
branch
2 times, most recently
from
8af3f5f to
07018d3
Compare
tnatt
force-pushed
the
require_volumetrics_columns
branch
2 times, most recently
from
8b0772c to
11a51b0
Compare
tnatt
force-pushed
the
require_volumetrics_columns
branch
from
11a51b0 to
b12e5c6
Compare
tnatt
commented
Dec 15, 2024
Comment on lines
+227
to
+236
| for col in ["BULK", "PORV", "HCPV"]: | ||
| if self._is_column_missing_in_table(col): | ||
| missing_calculations.append(col) | ||
|
|
||
| if has_oil and self._is_column_missing_in_table("STOIIP"): | ||
| missing_calculations.append("STOIIP") | ||
|
|
||
| if has_gas and self._is_column_missing_in_table("GIIP"): | ||
| missing_calculations.append("GIIP") |
There was a problem hiding this comment.
Would be nice to convert these strings to enums #920
tnatt
force-pushed
the
require_volumetrics_columns
branch
2 times, most recently
from
20901e3 to
e82ce98
Compare
tnatt
force-pushed
the
require_volumetrics_columns
branch
from
e82ce98 to
4d81ae9
Compare
jcrivenaes
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that sets
BULK,PORV,HCPVas required in addition to andSTOIIP/GIIPdepending on what fluid has been selected.It is done by validating the final table before export.
Closes #900