ENH: Add ERT WF to copy preprocessed data #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrivenaes
reviewed
Jun 28, 2024
jcrivenaes
reviewed
Jun 28, 2024
mferrera
approved these changes
Jul 1, 2024
Comment on lines
+148
to
+149
| parser.add_argument( | ||
| "--verbosity", type=str, help="Set log level", default="WARNING" | ||
| ) |
There was a problem hiding this comment.
Should this be deprecated like other verbosity options in dataio?
|
|
||
| if not Path(args.ert_caseroot).is_absolute(): | ||
| logger.debug("Argument 'ert_caseroot' was not absolute: %s", args.ert_caseroot) | ||
| raise ValueError("'ert_caseroot' must be an absolute path") |
There was a problem hiding this comment.
argparse.ArgumentError is another option here, but I see this is most likely taken from create_case_metadata
| logger.setLevel(args.verbosity) | ||
|
|
||
| searchpath = Path(args.ert_config_path) / args.inpath | ||
| match_pattern = "[!.]*" # ignore metafiles (starts with '.') |
There was a problem hiding this comment.
Is there any possibility this ignores other files we want? (I assume not: but just a sanity check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that adds an ERT plugin workflow
WF_COPY_PREPROCESSED_DATAIOto replace the use of the locally installed workflow showcased in Drogon:Naming and arguments were kept the same as in Drogon to make this a drop-in replacement for the users that have implemented the Drogon workflow.
Main differences with the Drogon script is that this PR uses the new
ExportPreprocessedDataclass to export the data. This enables:Addresses #702