-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: Give deprecation warning for arguments in kwargs #701
Conversation
self._classification = self._get_classification() | ||
self._rep_include = self._get_rep_include() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved into the update_check_settings()
as it is only needed to run if any of classification/rep_include/access_ssdl
is coming in through kwargs.
And hence it can be removed together with the entire update_check_settings()
method when the deprecation period has ended.
I think this is a solid approach. I am not sure it's worth the effort, but we could consider creating a |
b23df43
to
3bd3866
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
PR to start emitting a deprecation warning for arguments coming in through kwargs in the
ExportData.generate_metadata()
andExportData.export()
methods.Addresses #525