DEP: Deprecate fmu_context='preprocessed' #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me this feels like the best of the two proposed solutions in #593 |
tnatt
force-pushed
the
preprocessed_argument
branch
from
b9e0998 to
838c259
Compare
tnatt
force-pushed
the
preprocessed_argument
branch
from
838c259 to
843c059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to deprecate
fmu_context="preprocessed"and add apreprocessedargument insteadfmu_contextarguments from allExportDatainitializations, as it now is possible to use only ERT environment variables to infer the value of the context.Closes #593