Add utils tests #413
Merged
Add utils tests #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbjorge
commented
Jan 10, 2024
| def inside_rms(func): | ||
| """Decorator for being inside RMS""" | ||
|
|
||
| @wraps(func) | ||
| def wrapper(*args, **kwargs): | ||
| ExportData._inside_rms = True | ||
| retval = func(*args, **kwargs) |
There was a problem hiding this comment.
If func raises, revert to old state never happens. In my case, got a few tailing tests that failed.
janbjorge
added
enhancement
janbjorge
requested review from
mferrera,
perolavsvendsen and
tnatt
and removed request for
mferrera
mferrera
approved these changes
Jan 11, 2024
| @@ -45,15 +46,39 @@ def pytest_configure(): | |||
| cprint(80 * "=", "red", attrs=["blink"]) | |||
|
|
|||
|
|
|||
| @contextlib.contextmanager | |||
There was a problem hiding this comment.
Would it be reasonable to expose these context managers through fixtures?
Comment on lines
+61
to
+62
| unset = object() | ||
| old = os.environ.get("INSIDE_RMS", unset) |
There was a problem hiding this comment.
Interesting! For uniqueness?
There was a problem hiding this comment.
Yeah, just in case its set to None. If i do not use a sentinel value i want be able do differentiate between the two.
tests/test_units/test_utils.py
Outdated
Comment on lines
92
to
95
| assert utils.get_object_name(Polygons()) is None | ||
| assert utils.get_object_name(Polygons(name="Not poly")) == "Not poly" |
There was a problem hiding this comment.
Could be worth explicitly testing with Polygons(name="poly") is None as well since this seems like a default we could inadvertently change in the future without thinking it's relied upon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test coverage hunting: ~ 14% more coverage in the src/fmu/dataio/_utils.py
Before:
After: