Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new workspace using API #53

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Conversation

OleksSokolov
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Feb 15, 2023

Unit Test Results

245 tests  ±0   245 ✔️ ±0   9s ⏱️ -1s
    8 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 1663880. ± Comparison against base commit ffd4c0e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 15, 2023

End-to-end test results

13 tests  +1   12 ✔️ +1   0s ⏱️ ±0s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 1663880. ± Comparison against base commit ffd4c0e.

♻️ This comment has been updated with latest results.

@OleksSokolov
Copy link
Contributor Author

Example for testing
Screenshot 2023-02-15 at 23 37 51

URL: POST http://localhost:8080/flowify-server/api/v1/workspaces/
Body:
{ "Name":"new-workspace", "Roles":["sandbox-developer"] }

@adamchengtkc
Copy link
Collaborator

Does it allow specifying admin and user role in a workspace?

@OleksSokolov
Copy link
Contributor Author

Does it allow specifying admin and user role in a workspace?

@adamchengtkc no I believe specifying admin and user roles in workspaces is a separate issue

@adamchengtkc
Copy link
Collaborator

If I remember correctly, the admin role is already implemented (i.e user cannot access the secret page). Currently, the backend look for a "-admin" suffix in the role to determine role of a user. So in your example above. the backend currently will look for "sandbox-developer-admin" for admin role.

there is nothing wrong with this PR. Just to clarify the current implementation

@OleksSokolov
Copy link
Contributor Author

@adamchengtkc Thanks for the clarification, I understood the question now. You are absolutely right and yes it allows specifying admin and user roles in the new workspace

@adamchengtkc adamchengtkc merged commit 0a27aee into main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants