Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix csharpier not running in pipeline #1907

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix csharpier not running in pipeline #1907

merged 1 commit into from
Dec 20, 2024

Conversation

Christdej
Copy link
Contributor

@Christdej Christdej commented Dec 19, 2024 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Christdej Christdej added backend Backend related functionality improvement Improvement to existing functionality labels Dec 19, 2024
@Christdej Christdej self-assigned this Dec 19, 2024
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Dec 19, 2024
@Christdej
Copy link
Contributor Author

This PR only changes the appearance of files, not functionality

@Christdej Christdej force-pushed the fixlinelength branch 2 times, most recently from 9957050 to 375f76a Compare December 20, 2024 08:30
@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

Eddasol
Eddasol approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@Eddasol Eddasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Christdej Christdej merged commit f9fba4d into equinor:main Dec 20, 2024
14 checks passed
@Christdej Christdej deleted the fixlinelength branch December 20, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddasol Eddasol Eddasol approved these changes

Assignees

@Christdej Christdej

Labels
backend Backend related functionality database-change Will require migration improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Christdej @Eddasol