Improve inspections view stability #1890
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrica-equinor
force-pushed
the
new-inspections-view
branch
4 times, most recently
from
c1a3305 to
a8daf01
Compare
| { | ||
| return NotFound($"Could not find inspection blob {inspectionData.BlobName} in container {inspectionData.BlobContainer} and storage account {inspectionData.StorageAccount}."); | ||
| } | ||
| return File(inspectionStream, "image/png"); |
There was a problem hiding this comment.
Consider using Enums
| public Task<Inspection?> AddFinding(InspectionFindingQuery inspectionFindingsQuery, string isarTaskId); | ||
| public Task<IDAInspectionDataResponse?> GetInspectionStorageInfo(string inspectionId); | ||
| public Task<byte[]?> GetInspectionImage(string installationCode, string isarInspectionId); |
There was a problem hiding this comment.
consider renaming to GetInspectionData
| return null; | ||
| } | ||
|
|
||
| if (!inspectionData.BlobContainer.ToLower(CultureInfo.CurrentCulture).Equals(installationCode.ToLower(CultureInfo.CurrentCulture), StringComparison.Ordinal)) |
There was a problem hiding this comment.
Consider more readable check
|
|
||
| if (!inspectionData.BlobContainer.ToLower(CultureInfo.CurrentCulture).Equals(installationCode.ToLower(CultureInfo.CurrentCulture), StringComparison.Ordinal)) | ||
| { | ||
| logger.LogError($"Could not find inspection data for inspection with isar Id {inspection.IsarInspectionId} because blob name {inspectionData.BlobName} does not match installation {installationCode}."); |
There was a problem hiding this comment.
Do we compare name of the blob, or blob location?
There was a problem hiding this comment.
This is to make sure the blob container has the same name as the installation code, a bit reduntant but will help in case something goes wrong with the naming of the containers in the storage account. Agreed with Thomas it's worth keeping
There was a problem hiding this comment.
Nevermind, that was a mistake, tusen takk
There was a problem hiding this comment.
The log was wrong but the check was fine
mrica-equinor
force-pushed
the
new-inspections-view
branch
from
a8daf01 to
3de7ec8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review checklist: