Improve mission page #1848
Draft
Improve mission page #1848
+122
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrica-equinor
force-pushed
the
main
branch
3 times, most recently
from
f14103a to
acb193d
Compare
Eddasol
reviewed
Dec 6, 2024
| gap: 32px; | ||
| width: fit-content; | ||
| align-items: end; | ||
| } |
There was a problem hiding this comment.
Should info section be same width as rest? Also it doesn't seem centered with regards to height
Eddasol
reviewed
Dec 6, 2024
Comment on lines
+21
to
23
| background-color: ${tokens.colors.ui.background__light.hex}; | ||
| ` | ||
| const TitleSection = styled.div` |
There was a problem hiding this comment.
Suggest putting the "Add to queue"-button under the title on smal screen (maybe flex: wrap?)
Eddasol
reviewed
Dec 6, 2024
| <StyledTableCell>{TranslateText('Description')}</StyledTableCell> | ||
| <StyledTableCell>{TranslateText('Inspection Types')}</StyledTableCell> | ||
| <StyledTableCell>{TranslateText('Status')}</StyledTableCell> | ||
| <Table.Cell>#</Table.Cell> |
There was a problem hiding this comment.
Consider using different design for task table on small screen
Eddasol
reviewed
Dec 6, 2024
| @@ -9,6 +9,7 @@ import { Pose } from 'models/Pose' | |||
| import { MapCompass } from 'utils/MapCompass' | |||
| import { Deck } from 'models/Deck' | |||
| import { useLanguageContext } from 'components/Contexts/LanguageContext' | |||
| import { getMeta } from 'components/Pages/MissionPage/MapPosition/MissionMapView' | |||
There was a problem hiding this comment.
Should getMeta be in utils instead since its used by both? Maybe in a map utilities file (in a map folder?)?
There was a problem hiding this comment.
Or maybe not since deckMapView probably will disappear soon
Eddasol
reviewed
Dec 6, 2024
Comment on lines
+27
to
+31
| min-width: 50%; | ||
| max-width: fit-content; | ||
| min-height: 60%; |
There was a problem hiding this comment.
These values feel a bit arbitrary. Are they necessary?
Look at ContainButton for missionHistoryButton for inspiration
eivindsjovold
requested changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.