better handling of projection when end of path, allow for extension (#…

…171) * better handling of projection when end of path, allow for extension * clamp values when not using extension * removed extrapolation option until we have discussed it extensively Co-authored-by: Brynjulf <[email protected]>
equinor · Apr 17, 2020 · f3a50d4 · f3a50d4
1 parent 4ed4741
commit f3a50d4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/.storybook/src/layers/html/highlight.stories.ts b/.storybook/src/layers/html/highlight.stories.ts
@@ -113,8 +113,8 @@ export const HighlightWellborepathWithController = () => {
   // external event that calls the rescale event the highlighting should change
   const slider = createSlider((event: any) => onUpdate(event, { rescaleEvent: controller.currentStateAsEvent, layer: highlightLayer }), {
     width,
-    min: 0,
-    max: controller.referenceSystem.length,
+    min: -1000,
+    max: controller.referenceSystem.length + 1000,
   });
 
   root.appendChild(container);

diff --git a/src/control/IntersectionReferenceSystem.ts b/src/control/IntersectionReferenceSystem.ts
@@ -1,4 +1,5 @@
 import Vector2 from '@equinor/videx-vector2';
+import { clamp } from '@equinor/videx-math';
 import { CurveInterpolator, normalize } from 'curve-interpolator';
 import { Interpolator, Trajectory, ReferenceSystemOptions } from '../interfaces';
 
@@ -71,18 +72,15 @@ export class IntersectionReferenceSystem {
     this.endVector = IntersectionReferenceSystem.getDirectionVector(this.interpolators.trajectory, 1 - thresholdDirectionDist, 1);
     this.startVector = this.endVector.map((d: number) => d * -1);
   }
-
   /**
    * Map a length along the curve to intersection coordinates
+   * @param length length along the curve
    */
   project(length: number): number[] {
     const { curtain } = this.interpolators;
     const l = (length - this._offset) / this.length;
-    // TODO handle points outside
-    if (l < 0 || l > 1) {
-      return [0, 0];
-    }
-    const p = curtain.getPointAt(l);
+    const t = clamp(l, 0, 1);
+    const p = curtain.getPointAt(t);
     return p;
   }