Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid repeated logging for each cluster in misfit analysis #9626

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

berland
Copy link
Contributor

@berland berland commented Dec 27, 2024

Issue
Resolves #9347

Approach

Condense what is logged.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland self-assigned this Dec 27, 2024
@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (855c517) to head (5774332).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9626      +/-   ##
==========================================
- Coverage   91.73%   91.71%   -0.03%     
==========================================
  Files         430      430              
  Lines       26639    26639              
==========================================
- Hits        24437    24431       -6     
- Misses       2202     2208       +6     
Flag Coverage Δ
cli-tests 39.46% <100.00%> (ø)
everest-models-test 34.19% <0.00%> (-0.01%) ⬇️
gui-tests 71.83% <100.00%> (ø)
integration-test 38.30% <0.00%> (+<0.01%) ⬆️
performance-tests 51.69% <0.00%> (+<0.01%) ⬆️
test 39.62% <0.00%> (+<0.01%) ⬆️
unit-tests 73.98% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #9626 will not alter performance

Comparing berland:adjust_misfit_logging (5774332) with main (855c517)

Summary

✅ 24 untouched benchmarks

@eivindjahren
Copy link
Contributor

I suggest having either @dafeda or @oyvindeide have a look at this. Not sure what the original intent was behind the log statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve log statement from misfit_processor
3 participants