Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precision loss issue in calculation of standard deviation. #9625

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Dec 27, 2024

Issue
Resolves #9301

Approach

The problem was due to catastrophic precision loss in the standard deviation calculation.
This PR changes the update function so that standard deviation is calculated in 64 bit float
precision. It still remains to validate that this does not use too much memory.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren changed the title Fix update issue Fix precision loss issue in calculation of standard deviation. Dec 27, 2024
@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Dec 27, 2024
@eivindjahren eivindjahren force-pushed the fix_update_issue branch 2 times, most recently from 2ecd4b6 to 21fbfd6 Compare December 27, 2024 08:11
Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #9625 will not alter performance

Comparing eivindjahren:fix_update_issue (a87a4d4) with main (855c517)

Summary

✅ 24 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure in misfit preprocessor after warning
1 participant