Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SIMULATION_JOB keyword #9606

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove SIMULATION_JOB keyword #9606

wants to merge 1 commit into from

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Dec 20, 2024

Issue
Resolves #4955

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

❌ 10 Tests Failed:

Tests completed Failed Passed Skipped
2854 10 2844 97
View the top 3 failed tests by shortest run time
tests/ert/ui_tests/gui/test_plotting_of_snake_oil.py::::test_that_all_snake_oil_visualisations_matches_snapshot[plot_figure3-0]
Stack Traces | 0.019s run time
No failure message available
tests/ert/ui_tests/gui/test_plotting_of_snake_oil.py::::test_that_all_snake_oil_visualisations_matches_snapshot[plot_figure5-0]
Stack Traces | 0.019s run time
No failure message available
tests/ert/ui_tests/gui/test_plotting_of_snake_oil.py::::test_that_all_snake_oil_visualisations_matches_snapshot[plot_figure6-0]
Stack Traces | 0.019s run time
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #9606 will not alter performance

Comparing remove-simulation-job (1120a22) with main (722e0fc)

Summary

✅ 24 untouched benchmarks

@DanSava DanSava force-pushed the remove-simulation-job branch 3 times, most recently from 177cbb0 to 44499fd Compare December 20, 2024 12:43
@DanSava DanSava force-pushed the remove-simulation-job branch from 44499fd to 1120a22 Compare December 20, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SIMULATION_JOB
2 participants