Non optional everest model and nonzero realizations #9577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9368
Approach
Make
ModelConfig
required and enforcerealizations
length > 0. Add some more meaningful error messages too. I am still usinglist[NonNegativeInt]
(withmin_length=1
inField
) instead ofconlist
since this was ill-advised (see discussion here microsoft/pylance-release#5457).NOTE: If I don't add
if values is None:
we get this error whenmodel
is specified but left empty:'NoneType' object has no attribute 'get'
which doesn't tell the user anything :)(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable