Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use f-strings for formatting #9570

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Use f-strings for formatting #9570

merged 1 commit into from
Dec 19, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Dec 17, 2024

This commit only consists of the safe fixes that ruff can do

Issue
Resolves ruff issue UP032

Approach
ruff check --fix

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland self-assigned this Dec 17, 2024
@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (6ce4714) to head (d7723ba).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9570   +/-   ##
=======================================
  Coverage   91.85%   91.86%           
=======================================
  Files         433      433           
  Lines       26773    26773           
=======================================
+ Hits        24592    24594    +2     
+ Misses       2181     2179    -2     
Flag Coverage Δ
cli-tests 39.75% <ø> (ø)
everest-models-test 34.58% <0.00%> (+<0.01%) ⬆️
gui-tests 72.15% <ø> (+0.02%) ⬆️
integration-test 37.21% <100.00%> (+0.01%) ⬆️
performance-tests 51.95% <ø> (ø)
test 40.46% <100.00%> (ø)
unit-tests 74.19% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 17, 2024

CodSpeed Performance Report

Merging #9570 will not alter performance

Comparing berland:f-strings (d7723ba) with main (6ce4714)

Summary

✅ 22 untouched benchmarks

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📏

@berland berland enabled auto-merge (rebase) December 19, 2024 06:39
@berland berland merged commit a509da2 into equinor:main Dec 19, 2024
40 checks passed
@berland berland deleted the f-strings branch December 27, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants