Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Include spans for dark storage #9535

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

HakonSohoel
Copy link
Contributor

Issue
Resolves equinor/scout#1157

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@HakonSohoel HakonSohoel marked this pull request as draft December 13, 2024 09:57
@HakonSohoel HakonSohoel force-pushed the Include-spans-for-dark-storage branch from 4958390 to 9d7ee1b Compare December 13, 2024 15:01
Copy link

codspeed-hq bot commented Dec 13, 2024

CodSpeed Performance Report

Merging #9535 will not alter performance

Comparing HakonSohoel:Include-spans-for-dark-storage (080b057) with main (7f72c05)

Summary

✅ 22 untouched benchmarks

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 91.86%. Comparing base (01156bb) to head (080b057).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/services/_storage_main.py 28.12% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9535      +/-   ##
==========================================
+ Coverage   91.85%   91.86%   +0.01%     
==========================================
  Files         433      433              
  Lines       26768    26806      +38     
==========================================
+ Hits        24587    24626      +39     
+ Misses       2181     2180       -1     
Flag Coverage Δ
cli-tests 39.71% <13.04%> (-0.04%) ⬇️
everest-models-test 34.54% <4.34%> (-0.05%) ⬇️
gui-tests 74.42% <30.43%> (+2.30%) ⬆️
integration-test 37.15% <4.34%> (-0.05%) ⬇️
performance-tests 51.91% <17.39%> (-0.03%) ⬇️
test 40.42% <4.34%> (-0.03%) ⬇️
unit-tests 74.17% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add opentelemetry.instrumentation on server and client side
Fix azure log handler overriden by uvicorn.Config
This will include these log messages in azure
@HakonSohoel HakonSohoel force-pushed the Include-spans-for-dark-storage branch from 2c3d8c9 to e8d20e5 Compare December 18, 2024 14:09
@HakonSohoel HakonSohoel marked this pull request as ready for review December 18, 2024 14:16
@berland berland changed the title WIP: Include spans fro dark storage WIP: Include spans for dark storage Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants