Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error when everest fm_step reaches MAX_RUNTIME #9522

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Dec 12, 2024

Issue
Resolves #8760

Approach

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava added release-notes:improvement Automatically categorise as improvement in release notes release-notes:formatting PR with only text formatting changes labels Dec 12, 2024
@DanSava DanSava self-assigned this Dec 12, 2024
@DanSava DanSava force-pushed the report-max-runtime-error branch from 614afa8 to 78a9c4e Compare December 12, 2024 14:47
@DanSava DanSava force-pushed the report-max-runtime-error branch from 78a9c4e to 8e0604b Compare December 16, 2024 08:42
Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #9522 will not alter performance

Comparing DanSava:report-max-runtime-error (91c661a) with main (e5c7953)

Summary

✅ 22 untouched benchmarks

@DanSava DanSava force-pushed the report-max-runtime-error branch 3 times, most recently from 7dfa009 to b3bb31e Compare December 16, 2024 09:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (d875982) to head (91c661a).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9522      +/-   ##
==========================================
+ Coverage   91.64%   91.86%   +0.22%     
==========================================
  Files         433      433              
  Lines       26722    26780      +58     
==========================================
+ Hits        24489    24602     +113     
+ Misses       2233     2178      -55     
Flag Coverage Δ
cli-tests 39.74% <0.00%> (+0.33%) ⬆️
everest-models-test 34.58% <0.00%> (?)
gui-tests 72.12% <0.00%> (-0.09%) ⬇️
integration-test 37.18% <27.27%> (-0.08%) ⬇️
performance-tests 51.95% <0.00%> (-0.05%) ⬇️
test 40.70% <100.00%> (+0.19%) ⬆️
unit-tests 74.17% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have some minor comments regarding the test that you can take into account if you agree.The patch comment should probably be in a separate commit if you end up doing it.

tests/everest/test_everserver.py Outdated Show resolved Hide resolved
tests/everest/test_everserver.py Outdated Show resolved Hide resolved
Also log the error in forward_models.log
@DanSava DanSava force-pushed the report-max-runtime-error branch from 6176c18 to dbffe84 Compare December 19, 2024 08:29
@DanSava DanSava merged commit a159fa7 into equinor:main Dec 19, 2024
41 checks passed
@DanSava DanSava deleted the report-max-runtime-error branch December 19, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
christmas-review release-notes:formatting PR with only text formatting changes release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reporting for users when the max_runtime limit is reached.
4 participants