-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show error when everest fm_step reaches MAX_RUNTIME #9522
Conversation
614afa8
to
78a9c4e
Compare
78a9c4e
to
8e0604b
Compare
CodSpeed Performance ReportMerging #9522 will not alter performanceComparing Summary
|
7dfa009
to
b3bb31e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9522 +/- ##
==========================================
+ Coverage 91.64% 91.86% +0.22%
==========================================
Files 433 433
Lines 26722 26780 +58
==========================================
+ Hits 24489 24602 +113
+ Misses 2233 2178 -55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have some minor comments regarding the test that you can take into account if you agree.The patch comment should probably be in a separate commit if you end up doing it.
Also log the error in forward_models.log
6176c18
to
dbffe84
Compare
Issue
Resolves #8760
Approach
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable