Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin pydantic #9514

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Unpin pydantic #9514

merged 1 commit into from
Dec 18, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Dec 11, 2024

Issue
Resolves #9292

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (0e19012) to head (57c5943).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9514      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.01%     
==========================================
  Files         433      433              
  Lines       26770    26771       +1     
==========================================
- Hits        24595    24594       -1     
- Misses       2175     2177       +2     
Flag Coverage Δ
cli-tests 39.76% <100.00%> (+<0.01%) ⬆️
everest-models-test 34.65% <100.00%> (-0.01%) ⬇️
gui-tests 72.14% <100.00%> (+<0.01%) ⬆️
integration-test 37.20% <100.00%> (-0.01%) ⬇️
performance-tests 51.94% <100.00%> (+<0.01%) ⬆️
test 40.45% <100.00%> (+<0.01%) ⬆️
unit-tests 74.16% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj marked this pull request as ready for review December 12, 2024 11:21
@larsevj larsevj requested a review from oyvindeide December 12, 2024 13:29
@larsevj larsevj self-assigned this Dec 12, 2024
@larsevj larsevj force-pushed the unpin_pydantic_210 branch 2 times, most recently from 2c7bfc8 to 8bb0180 Compare December 13, 2024 14:44
@equinor equinor deleted a comment from codspeed-hq bot Dec 17, 2024
Copy link

codspeed-hq bot commented Dec 17, 2024

CodSpeed Performance Report

Merging #9514 will not alter performance

Comparing larsevj:unpin_pydantic_210 (57c5943) with main (0e19012)

Summary

✅ 22 untouched benchmarks

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this, but we agreed to create an issue to figure out the root cause.

@larsevj larsevj added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 18, 2024
@larsevj larsevj merged commit a6649a1 into equinor:main Dec 18, 2024
41 checks passed
@larsevj larsevj deleted the unpin_pydantic_210 branch December 18, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unpin pydantic version
5 participants