Type code in src/ert/resources #9502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping eclrun/flow as it will be dealt with in another PR.
berland
added
the
release-notes:skip
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9502 +/- ##
==========================================
+ Coverage 91.92% 91.94% +0.02%
==========================================
Files 433 433
Lines 26734 26734
==========================================
+ Hits 24575 24581 +6
+ Misses 2159 2153 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
berland
commented
Dec 11, 2024
| @@ -67,6 +70,7 @@ def run( | |||
| # Use the keys (UUIDs as strings) to get ensembles | |||
| ensembles = [] | |||
| for ensemble_id in ensemble_data_as_dict: | |||
| assert self.storage is not None | |||
There was a problem hiding this comment.
(this smells a little bit, can't see how the storage function argument is used)
There was a problem hiding this comment.
Why is self.storage used instead of the parameter storage ? Is this some sort of backwards compatability thing @oyvindeide ?
eivindjahren
added
release-notes:maintenance
We have bigger problems there: #9525 |
eivindjahren
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping eclrun/flow as it will be dealt with in another PR.
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable