Name job after its executable when not specified #9438
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9438 +/- ##
==========================================
+ Coverage 91.85% 91.87% +0.02%
==========================================
Files 433 433
Lines 26767 26770 +3
==========================================
+ Hits 24586 24595 +9
+ Misses 2181 2175 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #9438 will not alter performanceComparing Summary
|
| runpath: Path | None = None, | ||
| num_cpu: int | None = 1, | ||
| realization_memory: int | None = 0, | ||
| ) -> None: | ||
| if runpath is None: | ||
| runpath = Path.cwd() | ||
| if name is None: | ||
| name = Path(executable).name |
There was a problem hiding this comment.
This spurred this "bug": #9564 (but it does not have to be solved in this PR since the problem existed beforehand)
berland
added
the
release-notes:maintenance
|
Thanks for your contribution. I think this looks very good. Can you squash the commits into one? |
Done! |
Issue
Resolves #9437
Approach
When the parameter
nameofdriver.submit()is not set, replace it with the executable name.git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable