Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport test fixes to version-11.0 #9134

Closed
wants to merge 6 commits into from

Conversation

sondreso
Copy link
Collaborator

@sondreso sondreso commented Nov 1, 2024

Issue
Cannot get release out

Approach
Backport fixes

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

larsevj and others added 4 commits November 1, 2024 14:43
Validation is raised from dispatch_event_from_json so
event is unbound.
This commit adds an auto-used fixture for all cli tests, that sets the environment variable for numpy multithreading `OMP_NUM_THREADS` to 1.
This might have been the cause of those tests hanging, as numpy uses all resources available if the env variable is not explicitly set.
@sondreso sondreso self-assigned this Nov 1, 2024
@sondreso sondreso requested a review from eivindjahren November 1, 2024 14:00
Starting the realizations in scheduler was blocking all other async tasks
from running. Nothing could connect to ensemble evaluator during this.
Under heavy load this could cause Monitor to time out and fail. Now we will
sleep(0) between each time we create a new subprocess. This will allow
other asyncio tasks to run.
@sondreso sondreso enabled auto-merge (rebase) November 1, 2024 14:17
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

And add some explanation for further debugging
@sondreso sondreso disabled auto-merge November 12, 2024 11:09
@sondreso sondreso closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants