Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport step logging #9109

Closed
wants to merge 2 commits into from
Closed

Backport step logging #9109

wants to merge 2 commits into from

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 31, 2024 •
edited
Loading

Backport logging of step runtime.

Approach
♻️

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland
Change event names from job to step
b39a783
@berland
Log runtime for individual forward model steps
680024e 
This is meant for making statistics pr forward model step name.

While testing on poly_example and local queue, there
is some odd occurences of the logged message that start_time
is None, this is not believed to happen often in production.
@berland berland self-assigned this Oct 31, 2024
@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Oct 31, 2024
@berland berland enabled auto-merge (rebase) October 31, 2024 08:39
@berland berland disabled auto-merge October 31, 2024 08:58
@berland berland closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eivindjahren eivindjahren eivindjahren approved these changes

Assignees

@berland berland

Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berland @eivindjahren