Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less aggressive LSF #9038

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 24, 2024

Issue
Resolves 🔥

Approach
🕐

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

This is to mitigate temporal bottleneck
issues with the LSF grid server.
@berland berland force-pushed the less_aggressive_lsf branch from 93d9c4d to a161f0e Compare October 24, 2024 13:25
@berland berland requested a review from sondreso October 24, 2024 13:26
@berland berland added maintenance Not a bug now but could be one day, repaying technical debt release-notes:maintenance Automatically categorise as maintenance change in release notes and removed maintenance Not a bug now but could be one day, repaying technical debt labels Oct 24, 2024
@berland berland enabled auto-merge (rebase) October 24, 2024 13:32
@berland berland merged commit 0ed17db into equinor:version-11.0 Oct 24, 2024
34 of 35 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.41%. Comparing base (5717e4d) to head (a161f0e).
Report is 9 commits behind head on version-11.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           version-11.0    #9038      +/-   ##
================================================
- Coverage         91.50%   91.41%   -0.09%     
================================================
  Files               343      343              
  Lines             21276    21335      +59     
================================================
+ Hits              19468    19504      +36     
- Misses             1808     1831      +23     
Flag Coverage Δ
cli-tests 38.96% <33.33%> (-0.02%) ⬇️
gui-tests 72.43% <33.33%> (+0.01%) ⬆️
performance-tests 49.26% <33.33%> (-0.06%) ⬇️
unit-tests 79.99% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland deleted the less_aggressive_lsf branch October 31, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants