Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submit fail leading to ensemble failures #9032

Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Oct 24, 2024

Backport of #8894 and #9008

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren changed the title Improve error messages on test komodo failures (#9008) Fix submit fail leading to ensemble failures Oct 24, 2024
@eivindjahren eivindjahren requested a review from sondreso October 24, 2024 07:19
@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Oct 24, 2024
@eivindjahren eivindjahren force-pushed the backport_submit_fail_fix branch from fedf0ce to c85e16f Compare October 24, 2024 07:23
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@eivindjahren eivindjahren force-pushed the backport_submit_fail_fix branch from c85e16f to 59d527c Compare October 24, 2024 07:49
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.30303% with 13 lines in your changes missing coverage. Please review.

Project coverage is 91.43%. Comparing base (cf17517) to head (59d527c).

Files with missing lines Patch % Lines
src/ert/scheduler/slurm_driver.py 58.33% 5 Missing ⚠️
src/ert/scheduler/job.py 63.63% 4 Missing ⚠️
src/ert/scheduler/lsf_driver.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           version-11.0    #9032      +/-   ##
================================================
- Coverage         91.47%   91.43%   -0.05%     
================================================
  Files               343      343              
  Lines             21294    21331      +37     
================================================
+ Hits              19479    19503      +24     
- Misses             1815     1828      +13     
Flag Coverage Δ
cli-tests 38.97% <46.96%> (-0.01%) ⬇️
gui-tests 72.42% <53.03%> (+0.04%) ⬆️
performance-tests 49.22% <36.36%> (-0.10%) ⬇️
unit-tests 80.02% <59.09%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren merged commit e47bc09 into equinor:version-11.0 Oct 24, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants