Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace interface towards eclrun and flow #8997

Closed
wants to merge 15 commits into from

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 18, 2024

Issue
Resolves #8925

Approach

  • "ecl_config"-concept is eradicated, this was the legacy way of running Eclipse prior to eclrun from SLB.
  • The eclrun wrapper we had was called EclRun. This is renamed to RunReservoirSimulator and handles both Eclipse and Flow.
  • Assumes there is a script/binary in $PATH called flowrun that has quite similar CLI as eclrun.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Oct 18, 2024
@berland berland self-assigned this Oct 18, 2024
@berland berland force-pushed the eclrun_using_pathhook branch from 59716c9 to 99d4183 Compare October 23, 2024 16:32
@berland
Copy link
Contributor Author

berland commented Oct 31, 2024

Superseded by #9108

@berland berland closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up EclRun
1 participant